[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master has switched from Automake to GNU Make
From: |
Noam Postavsky |
Subject: |
Re: master has switched from Automake to GNU Make |
Date: |
Tue, 11 Apr 2017 12:24:24 -0400 |
On Tue, Apr 11, 2017 at 12:21 PM, Michal Nazarewicz <address@hidden> wrote:
>> I never rebase. Whether and how I installed the hooks is beyond my
>> knowledge. But IIUC Michael who committed the changes in
>> SpecialCasing.txt did not install the hook.
>
> $ ll .git/hooks/
> total 16
> -rwx------ 1 mpn eng 452 Dec 3 2014 applypatch-msg*
> -rwx------ 1 mpn eng 4002 Jan 28 2016 commit-msg*
> -rwx------ 1 mpn eng 398 Dec 3 2014 pre-applypatch*
> -rwx------ 1 mpn eng 1419 Jul 27 2016 pre-commit*
> $ grep -ve ^# -e ^\$ .git/hooks/pre-commit
> LC_ALL=C
> export LC_ALL
> exec >&2
> . git-sh-setup
> git_diff='git diff --cached --name-only --diff-filter=A'
> ok_chars='\0+[=-=]./0-9A-Z_a-z'
> nbadchars=`$git_diff -z HEAD | tr -d "$ok_chars" | wc -c`
> if test "$nbadchars" -ne 0; then
> echo "File name does not consist of -+./_ or ASCII letters or digits."
> exit 1
> fi
> for new_name in `$git_diff HEAD`; do
> case $new_name in
> -* | */-*)
> echo "$new_name: File name component begins with '-'."
> exit 1;;
> ChangeLog | */ChangeLog)
> echo "$new_name: Please use git commit messages, not ChangeLog files."
> exit 1;;
> esac
> done
> $ grep -ve ^# -e ^\$ .git/hooks/pre-applypatch
It looks like you're missing the whitespace check in pre-commit, this line:
exec git diff-index --check --cached HEAD --
Perhaps you installed the hooks before that was added?
- Re: master has switched from Automake to GNU Make, (continued)
Re: master has switched from Automake to GNU Make, Noam Postavsky, 2017/04/11
Re: master has switched from Automake to GNU Make, Michal Nazarewicz, 2017/04/11
Re: master has switched from Automake to GNU Make,
Noam Postavsky <=
Re: master has switched from Automake to GNU Make, Michal Nazarewicz, 2017/04/12