[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer

From: Stefan Monnier
Subject: Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466)
Date: Thu, 13 Apr 2017 14:37:03 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

>> - Why would we want to run abort-recursive-edit when we're in the minibuffer?
> I clearly remember that the intention was to discard the minibuffer when
> the user clicks on the big cross, i.e. the "Close" button in the toolbar,
> because its mnemonics suggests to close the currently active buffer -
> if it's the minibuffer, then close the minibuffer.

I see, thanks, that makes sense, indeed.

>> - Why did we decide to use menu-bar-non-minibuffer-window-p rather than
>> checking something like (window-minibuffer-p (frame-selected-window))?
> ‘menu-bar-non-minibuffer-window-p’ already does this, and additionally
> takes into account ‘menu-updating-frame’ and checks for ‘frame-live-p’.

But that's exactly the question: why pay attention to
menu-updating-frame and  frame-live-p?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]