[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer
From: |
Juri Linkov |
Subject: |
Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466) |
Date: |
Fri, 14 Apr 2017 02:35:08 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (x86_64-pc-linux-gnu) |
>> In any case it makes no sense to add special-casing for the minibuffer in
>> ‘kill-current-buffer’ since it is necessary only in ‘kill-this-buffer’
>> associated with the tool-bar/menu-bar.
>
> Alas, a couple of users of kill-this-buffer were sometimes calling it
> in the context of a menu-invoked command, so that part still can make
> sense. And I have no idea which of the callers relied on this feature
> even when invoking the function via non-menu events. It's been 9
> years since this feature was introduced.
I'm sure that all these callers used kill-this-buffer because there was no
kill-current-buffer to simply kill the current buffer, and nothing more.
So I think we need to leave kill-this-buffer callers only in menu-bar/tool-bar,
and use kill-current-buffer everywhere else, leaving just
‘(kill-buffer (current-buffer))’ in the definition of
kill-current-buffer in simple.el.
- Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466), Stefan Monnier, 2017/04/12
- Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466), Juri Linkov, 2017/04/12
- Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466), Eli Zaretskii, 2017/04/13
- Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466), Eli Zaretskii, 2017/04/14
- Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466), Stefan Monnier, 2017/04/16
- Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466), martin rudalics, 2017/04/16
- Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466), Stefan Monnier, 2017/04/16
- Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466), martin rudalics, 2017/04/16
- Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466), Eli Zaretskii, 2017/04/16
- Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466), Stefan Monnier, 2017/04/16
- Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466), Eli Zaretskii, 2017/04/16