emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix potentially hanging url-auth tests


From: Jarno Malmari
Subject: [PATCH] Fix potentially hanging url-auth tests
Date: Sat, 15 Apr 2017 12:12:44 +0300

* test/lisp/url/url-auth-tests.el (url-auth-test-digest-auth-retrieve-cache):
(url-auth-test-digest-auth, url-auth-test-digest-auth-opaque):
Set auth-sources variable to nil.
---
 test/lisp/url/url-auth-tests.el | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/test/lisp/url/url-auth-tests.el b/test/lisp/url/url-auth-tests.el
index 30636db..47aafab 100644
--- a/test/lisp/url/url-auth-tests.el
+++ b/test/lisp/url/url-auth-tests.el
@@ -137,7 +137,9 @@ url-auth-test-challenges
   "Check how the entry point retrieves cached authentication.
 Essential is how realms and paths are matched."
 
-  (let* ((url-digest-auth-storage
+  (let* ((auth-sources nil) ; Don't use any user authinfo files.  They
+                            ; may even hang the test run if encrypted.
+         (url-digest-auth-storage
           '(("example.org:80"
              ("/path/auth1" "auth1user" "key")
              ("/path" "pathuser" "key")
@@ -231,7 +233,8 @@ url-auth-test-challenges
 cnonce is used for generating them which is not mocked by the
 test and cannot be passed by arguments to `url-digest-auth'."
   (dolist (challenge url-auth-test-challenges)
-    (let* ((attrs (append
+    (let* ((auth-sources nil) ; Don't use any user authinfo files.
+           (attrs (append
                    (list (cons "nonce" (plist-get challenge :nonce)))
                    (if (plist-get challenge :qop)
                        (list (cons "qop" (plist-get challenge :qop))))))
@@ -276,7 +279,8 @@ url-auth-test-challenges
 (ert-deftest url-auth-test-digest-auth-opaque ()
   "Check that `opaque' value is added to result when presented by
 the server."
-  (let* ((url-digest-auth-storage
+  (let* ((auth-sources nil) ; Don't use any user authinfo files.
+         (url-digest-auth-storage
           '(("example.org:80" ("/" "user" "key"))))
          (attrs (list (cons "nonce" "anynonce")))
          auth)
-- 
2.7.0.25.gfc10eb5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]