emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Advice needed on modeline customization hack...


From: Eli Zaretskii
Subject: Re: Advice needed on modeline customization hack...
Date: Mon, 17 Apr 2017 09:02:47 +0300

> Date: Sun, 16 Apr 2017 18:06:20 -0400
> From: "Perry E. Metzger" <address@hidden>
> Cc: Stefan Monnier <address@hidden>, address@hidden
> 
> I found an issue, though, which is that there's code throughout
> xdisp.c that checks if w->column_number_displayed is the same as
> current_column() in order to decide if it should update the modeline.
> Naturally what I've done will break that.
> 
> I'm thinking perhaps I should add a flag to the window structure
> instead that says "add one when printing this" instead of changing
> the value of w->column_number_displayed, but I can't quite figure out
> where the modeline actually gets printed, only where
> column_number_displayed gets set.

I don't think adding a flag to the window object is necessary, as this
option is global.  You just need to make mode_line_update_needed look
at the new variable, and offset the displayed column by one if the
one-based display is used.  Will this work, or am I missing something?

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]