[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 491531b: Avoid ert test failures

From: Glenn Morris
Subject: Re: master 491531b: Avoid ert test failures
Date: Wed, 19 Apr 2017 16:38:47 -0400
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Noam Postavsky wrote:

>> +  (require 'bytecomp)                   ; FIXME?
> Anyway, I was considering fixing this by using (bound-and-true-p
> byte-compile-macro-environment) instead of loading `bytecomp', which
> almost seems to work except that eval-tests--bugs-24912-and-24913
> fails because `should-error' fails to catch the error from
> byte-compile.  That can be fixed by adding (require 'bytecomp) in that
> test, but maybe it's better just to leave the require in ert?
> 1: 2016-12-06 22:20:23 -0500 58e418d2ceb82501f03d9c3316fd0a46faf7f0eb
>   Fix ert-tests when running compiled

The above was just a workaround I threw in to stop the test failures.
I think explicitly loading bytecomp isn't great, and would welcome
any better solution. Maybe the original tests that caused this issue
simply aren't sensible.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]