[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Support threads in modules

From: Eli Zaretskii
Subject: Re: [PATCH] Support threads in modules
Date: Sat, 22 Apr 2017 22:49:45 +0300

> From: Philipp Stephani <address@hidden>
> Date: Sat, 22 Apr 2017 19:21:35 +0000
> Cc: address@hidden, address@hidden
>  Can you explain the purpose of these changes and the motivation? A
>  module shouldn't be restricted to be used by a single thread, should
>  it?
> No, but the thread used to create an environment object, the current Emacs 
> thread, and the current OS thread
> all have to match. Right now this isn't checked; the current code checks only 
> for the main thread, which isn't
> correct any more now that there can be more than one interpreter thread. 

I agree that checking for the main thread is not TRT, but why not
allow any thread of those in all_threads?  Why do we care that the env
pointer was created by the same thread as the one using it?  We should
only care that the invoking thread is one of the Emacs application
threads, no?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]