[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Introduce new misc type for module function

From: Philipp Stephani
Subject: Re: [PATCH] Introduce new misc type for module function
Date: Sun, 23 Apr 2017 15:34:39 +0000

Aurélien Aptel <address@hidden> schrieb am So., 23. Apr. 2017 um 17:19 Uhr:
Hi Philipp,

Nice to see you work on modules :)

* Shouldn't we try to map module function to subr instead of adding
another type?

Eventually yes, but I'd prefer to do that later and introduce the misc subtype now to get rid of the most pressing problems associated with using the save pointer (probably wrong type, no garbage collection). Turning module functions into proper subrs is a bit more involved since all pieces of code that touch subrs need to be adapted.
* Should we get rid of make_global_ref? It serves no purpose anymore
IIUC since you can't reuse emacs_values between module function calls.

My understanding is that the emacs_value objects returned from make_global_ref should be usable across environments and threads; at least that's my understanding of both the desired and the implemented behavior. 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]