[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: lisp/term/ns-win.el modification
From: |
Jean-Christophe Helary |
Subject: |
Re: lisp/term/ns-win.el modification |
Date: |
Thu, 4 May 2017 17:50:19 +0900 |
Anders,
Thank you for the verification. Would you mind checking that this patch is
correct before I propose it for a commit?
The log message would be something like:
===========================
Fix Multiline support in NS "open-file" service previous patch
* lisp/term/ns-win.el (ns-open-file-service): removed a useless check and fixed
a typo.
===========================
Jean-Christophe
ns-win.el.diff
Description: Binary data
> On May 4, 2017, at 5:40, Anders Lindgren <address@hidden> wrote:
>
> Hi!
>
> I just tested your latest patch. The code looks much cleaner now when you use
> `split-string'. (I didn't know it could all those tricks -- it's always good
> to learn something new!)
>
> The patch seems to work perfectly!
>
> Some minor details:
>
> * You no longer need the `(if (not (equal "" filestring"))' test -- when the
> OMIT-NULLS argument is non-nil, `split-string' ensures that the list doesn't
> contain empty strings.
>
> * You misspelled "trimmed" as "timmed" in the comment in
> `ns-open-file-service'.
>
> -- Anders
- Re: lisp/term/ns-win.el modification, (continued)
- Re: lisp/term/ns-win.el modification, Jean-Christophe Helary, 2017/05/01
- Re: lisp/term/ns-win.el modification, Eli Zaretskii, 2017/05/01
- Re: lisp/term/ns-win.el modification, Jean-Christophe Helary, 2017/05/01
- Re: lisp/term/ns-win.el modification, Eli Zaretskii, 2017/05/01
- Re: lisp/term/ns-win.el modification, Jean-Christophe Helary, 2017/05/02
- Re: lisp/term/ns-win.el modification, Anders Lindgren, 2017/05/03
- Re: lisp/term/ns-win.el modification, Jean-Christophe Helary, 2017/05/03
- Re: lisp/term/ns-win.el modification,
Jean-Christophe Helary <=
- Re: lisp/term/ns-win.el modification, Anders Lindgren, 2017/05/04
- Re: lisp/term/ns-win.el modification, Jean-Christophe Helary, 2017/05/05