Re: [PATCH] Reimplement module functions

[Noam Postavsky]

On Sat, May 13, 2017 at 1:05 PM, Eli Zaretskii <address@hidden> wrote:

>> -DEFUN ("internal--module-call", Finternal_module_call, 
>> Sinternal_module_call, 1, MANY, 0,
>> -       doc: /* Internal function to call a module function.
>> -ENVOBJ is a save pointer to a module_fun_env structure.
>> -ARGLIST is a list of arguments passed to SUBRPTR.
>> -usage: (module-call ENVOBJ &rest ARGLIST)   */)
>> -  (ptrdiff_t nargs, Lisp_Object *arglist)
>> +Lisp_Object
>> +funcall_module (const struct Lisp_Module_Function *const envptr,
>> +                ptrdiff_t nargs, Lisp_Object *arglist)
>>  {
>
> I don't think we can simply remove a function that was already present
> in one or more Emacs releases.  We need to provide a backward
> compatibility layer, and definitely also mention this in NEWS.
>

Does an internal function like 'internal--module-call' really need all
that? AFAIK, it was not really meant to be used except in the
implementation of module_make_function.