[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Ignoring test error

From: Noam Postavsky
Subject: Re: Ignoring test error
Date: Mon, 12 Jun 2017 13:04:31 -0400

On Mon, Jun 12, 2017 at 10:33 AM, Philipp Stephani
<address@hidden> wrote:
> after commit 94306c8b0d61a53b19dcee18475ea8692b001f5d 'make foo.log' in the
> test directory exits successfully even if the test fails. I don't think that
> is the best behavior, because the exit status is often used to determine
> whether any test has failed. Rather, 'make check' should use 'make -k' for
> the tests.

How about this? (my initial attempt of just making the 'check' recipe
do '@${MAKE} -k check-doit ...' ran into the problem that the summary
was skipped on test failure)

--- i/test/Makefile.in
+++ w/test/Makefile.in
@@ -124,10 +124,9 @@ testloadfile =
 testloadfile = $*

-## Ignore any test errors so we can continue to test other files.
 %.log: %.elc
     $(AM_V_at)${MKDIR_P} $(dir $@)
-    -$(AM_V_GEN)HOME=/nonexistent $(emacs) -l ert -l $(testloadfile) \
+    $(AM_V_GEN)HOME=/nonexistent $(emacs) -l ert -l $(testloadfile) \
       --eval "(ert-run-tests-batch-and-exit ${SELECTOR_ACTUAL})" ${WRITE_LOG}

 ifeq (@HAVE_MODULES@, yes)
@@ -211,8 +210,9 @@ check-maybe:

 ## Run the tests.
 .PHONY: check-doit
-check-doit: ${LOGFILES}
-    @$(emacs) -l ert -f ert-summarize-tests-batch-and-exit $^
+    address@hidden -k ${LOGFILES}
+    @$(emacs) -l ert -f ert-summarize-tests-batch-and-exit ${LOGFILES}

 .PHONY: mostlyclean clean bootstrap-clean distclean maintainer-clean

reply via email to

[Prev in Thread] Current Thread [Next in Thread]