[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit)
From: |
Phillip Lord |
Subject: |
Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit) |
Date: |
Sat, 08 Jul 2017 22:02:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) |
Dmitry Gutov <address@hidden> writes:
> On 7/8/17 2:53 PM, Eli Zaretskii wrote:
>
>> It's actually more than that: patches submitted to Emacs need to
>> conform to our coding and various other standards: include
>> properly-formatted commit log messages, documentation, and (where
>> appropriate) tests, etc. Patch review could require cleanup changes
>> etc.
>
> That doesn't negate the advantages of integrated solutions like
> GitLab, though. Emacs is not the only project with standards.
>
> We often enforce those via code review, and GitLab helps with that.
And the process is much easier in most projects. Push to feature branch,
get comments, using line-level in diff commenting. Then fix, squash,
force push. Finally, single click merge, PR closes.
Phil
- Re: In support of Jonas Bernoulli's Magit, (continued)
- Re: In support of Jonas Bernoulli's Magit, Toon Claes, 2017/07/06
- Re: In support of Jonas Bernoulli's Magit, Mike Gerwitz, 2017/07/06
- Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Nicolas Petton, 2017/07/07
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Tino Calancha, 2017/07/07
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Nicolas Petton, 2017/07/07
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Ted Zlatanov, 2017/07/07
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Ævar Arnfjörð Bjarmason, 2017/07/08
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Dmitry Gutov, 2017/07/08
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Eli Zaretskii, 2017/07/08
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Dmitry Gutov, 2017/07/08
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit),
Phillip Lord <=
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Tim Cross, 2017/07/08
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Ævar Arnfjörð Bjarmason, 2017/07/08
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Eli Zaretskii, 2017/07/08
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Jean-Christophe Helary, 2017/07/08
- Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit), Mike Gerwitz, 2017/07/07
- Re: In support of Jonas Bernoulli's Magit, Richard Stallman, 2017/07/07
- Re: In support of Jonas Bernoulli's Magit (was: comparing code on different branches), Richard Stallman, 2017/07/07
Re: In support of Jonas Bernoulli's Magit (was: comparing code on different branches), Jonas Bernoulli, 2017/07/13