emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit)


From: Phillip Lord
Subject: Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit)
Date: Sat, 08 Jul 2017 22:02:44 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux)

Dmitry Gutov <address@hidden> writes:

> On 7/8/17 2:53 PM, Eli Zaretskii wrote:
>
>> It's actually more than that: patches submitted to Emacs need to
>> conform to our coding and various other standards: include
>> properly-formatted commit log messages, documentation, and (where
>> appropriate) tests, etc.  Patch review could require cleanup changes
>> etc.
>
> That doesn't negate the advantages of integrated solutions like
> GitLab, though. Emacs is not the only project with standards.
>
> We often enforce those via code review, and GitLab helps with that.

And the process is much easier in most projects. Push to feature branch,
get comments, using line-level in diff commenting. Then fix, squash,
force push. Finally, single click merge, PR closes.

Phil




reply via email to

[Prev in Thread] Current Thread [Next in Thread]