[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Native line numbers landed on master

From: Eli Zaretskii
Subject: Re: Native line numbers landed on master
Date: Sun, 16 Jul 2017 17:10:48 +0300

> From: Alex <address@hidden>
> Cc: address@hidden
> Date: Sun, 16 Jul 2017 01:30:16 -0600
> > cus-load.el is auto-generated.  Did the rule which updates it in
> > lisp/Makefile get running after your changes, and was cus-load.el
> > regenerated as result?  If not, maybe you need to run that rule by
> > hand.
> I'm still not well-versed in Emacs's build system. cus-load doesn't get
> updated automatically for me (I had to manually run the target). Is this
> expected?

Yes, I think so.

> It appears that no rule forces cus-load to be regenerated, and
> only bootstrap-clean removes the file.

Indeed, I think the idea is that you should go into the lisp directory
and run "make custom-deps" there by hand.  This only runs
automatically at bootstrap time.

> After pulling changes, all I do is run "make -j4"; is it recommended to
> run extra rules each time, or just when I notice issues?

The latter.

> >> Would it be better to skip creating a new defgroup and have all
> >> variables just be in the display group, or are you in favour of a new
> >> group just for line numbers?
> >
> > If it's a hassle to make a new group, we can stay in the display
> > group.
> It's not a hassle, but I was looking at the git-blame for cus-edit and
> noticed that most of the entries are quite old. Is this group important
> enough to add to the file?

Not terribly important, no.

> It looks like I could just leave the defgroup definition in
> display-line-numbers.el and the variables in cus-start.el can still use
> it without display-line-numbers.el being preloaded.
> Which file would you rather have it in?

All else being equal, I think having as much as possible in
display-line-numbers.el would be better, as it avoids scattering
related stuff across different files.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]