[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: make bootstrap error

From: Eli Zaretskii
Subject: Re: make bootstrap error
Date: Sun, 30 Jul 2017 17:11:39 +0300

> From: Tino Calancha <address@hidden>
> Date: Sun, 30 Jul 2017 20:35:06 +0900 (JST)
> cc: address@hidden, address@hidden, Emacs developers <address@hidden>
> > After commit 6f6639d6ed6c6314b2643f6c22498fc2e23d34c7
> > ls-lisp.el requires 'em-glob.  When eshell package is
> > compiled, teh following file is generated:
> > esh-groups.el
> >
> > but ls-lisp.el is compiled _before_ eshell, so that
> > esh-groups.el doesn't exist yet.
> I moved the "(require 'em-glob)" inside `ls-lisp--dired'
> to not break the build.

Thanks, but I think this is still a bit fragile: it assumes that
ls-lisp--dired will never be called before Eshell files are compiled,
which might one day become false.

How about simply adding to ls-lisp.el an autoload form for em-glob,
instead of requiring it (with a suitable comment explaining why it is

reply via email to

[Prev in Thread] Current Thread [Next in Thread]