[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacs HEAD broken with XPM option in 1b492fa

From: Ken Brown
Subject: Re: Emacs HEAD broken with XPM option in 1b492fa
Date: Mon, 4 Sep 2017 20:45:51 -0400
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 9/4/2017 3:23 PM, Ashish SHUKLA wrote:
On Tue, 05 Sep 2017 00:48:21 +0530, address@hidden (Ashish SHUKLA) said:
| On Mon, 04 Sep 2017 21:30:13 +0300, Eli Zaretskii <address@hidden> said:
| || From: Paul Eggert <address@hidden>
| || Date: Mon, 4 Sep 2017 10:50:37 -0700
| || Cc: Noam Postavsky <address@hidden>
| ||
| || > It seems like in e88bbd22[2], author (cc'ed) typo-ed (s/X11/noX/):
| ||
| || A comment before that line says:
| ||
| || ### The Cygwin-w32 build uses <noX/xpm.h> instead of <X11/xpm.h>, so
| || ### we need to set LDFLAGS accordingly.
| ||
| || so presumably the noX is intentional. Perhaps this depends on Cygwin 
| || Sorry, I can't be of much help here since I don't use Cygwin.

| | The OP was evidently compiling for FreeBSD, so I wonder how that
| | compilation ends up in a Cygwin-specific part of the configure
| | script.  I guess some configure-time logic misfires on FreeBSD?

| Well, if you look carefully, there are two checks involving "noX/xpm.h" code
| snippet, one is for Windows/non-X11, and another is for X11. And,
| unfortunately both of those checks check for "noX/xpm.h", which I think is
| unintentional, and typo on author's part.

At following lines to be precise:


This use of "noX" is correct and is for the Cygwin-w32 build.


This one is wrong. It's surprising that it hasn't been noticed until now. I'll fix it shortly if no one beats me to it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]