[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Suspicious warning in W64 build

From: Andy Moreton
Subject: Re: Suspicious warning in W64 build
Date: Sat, 16 Sep 2017 14:17:15 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (windows-nt)

On Fri 15 Sep 2017, Eli Zaretskii wrote:

>> From: Fabrice Popineau <address@hidden>
>> Date: Fri, 15 Sep 2017 08:55:06 +0200
>> Cc: Emacs developers <address@hidden>
>>  # define pDWP "16llx"
>>  ^
>>  Should these be using the ptrdiff_t formatter pD from lisp.h ?
>> I'd rather cast the values to "long long unsigned int" as these values are 
>> assumed to be positive,
>> and would be meaningless if printed in decimal. 
> That's what I did.

The Mingw64 32bit build still has warnings in unexw32.c, which the
following fixes:

diff --git a/src/unexw32.c b/src/unexw32.c
index 0c6b48342e..e97a52ba07 100644
--- a/src/unexw32.c
+++ b/src/unexw32.c
@@ -471,7 +471,7 @@ get_section_info (file_data *p_infile)
 /* Format to print a DWORD_PTR value.  */
-#ifdef MINGW_W64
+#if defined MINGW_W64 && defined _WIN64
 # define pDWP  "16llx"
 # define pDWP  "08lx"

With this change I get clean builds on mingw64 32bit and 64bit.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]