[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] scratch/flymake-refactor b75f7e2: Hook Flymake onto pr

From: Stefan Monnier
Subject: Re: [Emacs-diffs] scratch/flymake-refactor b75f7e2: Hook Flymake onto proper checkdoc and byte-compile interfaces
Date: Sun, 01 Oct 2017 23:14:53 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

>>> * lisp/emacs-lisp/bytecomp.el
>>> (byte-compile-log-warning-function): New variable.
>>> (byte-compile-log-warning): Use it.
>>> (byte-compile--log-warning-for-byte-compile): New function.
>> Looking at it, I think it'd be more useful to add
>> a `display-warning-function` which applies to all calls to
>> display-warning.
> OTOH, we're not exactly "displaying" a warning, we're collecting one.

I'm just pointing out that moving the hook from byte-compile-log-warning
to display-warning would make it more generally useful.

> No problem. As I think I said in the commit message these two "proper"
> interfaces are just pure boilerplate. Feel free to change them.

I think for checkdoc, the hook looks good enough.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]