[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs-26 6dfc778 2/2: Fix fullscreen crash on macOS (b
Re: [Emacs-diffs] emacs-26 6dfc778 2/2: Fix fullscreen crash on macOS (bug#28496)
Sun, 8 Oct 2017 16:54:14 +0100
On Sat, Oct 07, 2017 at 06:52:21PM -0400, Stefan Monnier wrote:
> > + ;; Manipulating a frame without waiting for the fullscreen
> > + ;; animation to complete can cause a crash, or other unexpected
> > + ;; behaviour, on macOS (bug#28496).
> > + (when (featurep 'cocoa) (sit-for 1))))
> Then sit-for is not sufficient: it will often not wait at all (e.g. if
> the user has already hit further keys).
> `sleep-for` would make sure we really do wait a full second.
OK, thanks. I’ll change it.
> This said, we don't know if 1s is sufficient anyway, so maybe it doesn't
> matter that much: this is just a quick-hack kind of workaround.
Yes, I’m not very happy with this fix, but I can’t see any sensible
way around it.