Re: Old-style backquotes

[Eli Zaretskii]

> From: Philipp Stephani <address@hidden>
> Date: Sun, 08 Oct 2017 14:58:45 +0000
> Cc: address@hidden
> 
> OK, here's a patch. 

Thanks, a few minor comments:

> @@ -3178,10 +3171,7 @@ read1 (Lisp_Object readcharfun, int *pch, bool 
> first_in_list)
>          first_in_list exception (old-style can still be obtained via
>          "(\`" anyway).  */
>       if (!new_backquote_flag && first_in_list && next_char == ' ')
> -       {
> -         Vlread_old_style_backquotes = Qt;
> -         goto default_label;
> -       }
> +          load_error_old_style_backquotes ();

Here (and elsewhere) the indentation should be fixed to be in line
with our style.

> --- a/test/src/lread-tests.el
> +++ b/test/src/lread-tests.el
> @@ -173,13 +173,13 @@ lread-tests--last-message
>      (should (string-suffix-p "/somelib.el" (caar load-history)))))
>  
>  (ert-deftest lread-tests--old-style-backquotes ()
> -  "Check that loading warns about old-style backquotes."
> +  "Check that loading doesn’t accept old-style backquotes."

Please don't use literal curved quotes in doc strings and message
text, they will be transformed (by default) when displayed.