emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-26 aca5f00: Avoid encoding errors in message.el


From: Eli Zaretskii
Subject: Re: [Emacs-diffs] emacs-26 aca5f00: Avoid encoding errors in message.el
Date: Mon, 09 Oct 2017 19:18:14 +0300

> From: Stefan Monnier <address@hidden>
> Cc: address@hidden
> Date: Mon, 09 Oct 2017 11:57:11 -0400
> 
> > -      (set (make-local-variable (car local))
> > -           (cdr local)))))
> > +      ;; Cloning message-default-charset could cause an already
> > +      ;; encoded text to be encoded again, yielding raw bytes
> > +      ;; instead of characters in the message.
> > +      (unless (string-match "message-default-charset"
> > +                            (symbol-name (car local)))
> > +        (set (make-local-variable (car local))
> > +             (cdr local))))))
> 
> Could you add a comment explaining why we do
> 
>     (string-match "message-default-charset" (symbol-name (car local))
> 
> rather than
> 
>     (eq 'message-default-charset (car local))

No reason except that this was in the patch proposed by Alex.  Feel
free to change.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]