[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file com

From: Noam Postavsky
Subject: Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation
Date: Thu, 4 Jan 2018 08:22:12 -0500

On Thu, Jan 4, 2018 at 4:40 AM, Robert Cochran
<address@hidden> wrote:

> Attached is a patch that adds the variable `byte-compile-error-on-warn'
> to the safe variable list temporarily during calls to
> `byte-compile-file`, so that individual files can easily and simply
> include "byte-compile-error-on-warn: t" in their file local variables.

Wouldn't it be simpler and clearer to make it permanently safe? (PS
you can use #'booleanp instead of listing t and nil).

> For example, something that is bothering me right now
> is that there are quite a few 'foo is obsolete' warnings during the byte
> compilation portion of the build phase. Enabling error on warning means
> that trying to byte compile files that reference stale
> functions/variables/what have you will fail, prompting patches that
> obsolete Lisp objects to also fix usage of it in the core with the
> appropriate recommended replacement.

Solving Bug#4837 would be helpful for this, as currently there is no
practical way to fix/suppress the obsolete warnings in the code that
remains to support the obsolete option.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]