[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: kqueue.c and <sys/file.h>

From: Michael Albinus
Subject: Re: kqueue.c and <sys/file.h>
Date: Fri, 05 Jan 2018 15:09:33 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Jeremie Courreges-Anglas <address@hidden> writes:

> Hi,

Hi Jeremie,

> While sys/file.h has been around since some time now, it is not part of
> the POSIX standard (or any standard that I know of), and it looks like
> most of its consumers really want to include <fcntl.h> instead to access
> the various O_* #defines used by open(2).
> Within Emacs, src/kqueue.c seems to be the only source file that depends
> on sys/file.h to build on OpenBSD.  As discussed with Michael Albinus,
> I'd suggest using fcntl.h there (trivial diff below).  I guess it should
> be tested on other systems that provide kqueue(2) (*BSD, OSX, ?) but
> I don't expect fallout.

Thanks for this! Pls provide also a ChangeLog entry with reasoning for
this patch.

Let's wait a week or so. If nobody complains, I'll commit the patch to
the master branch then, in your name.

Best regards, Michael.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]