[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 5f72004: Revert "Fix command repetition with le
Re: [Emacs-diffs] master 5f72004: Revert "Fix command repetition with lexical-binding (Bug#29334)"
Tue, 09 Jan 2018 08:11:23 -0500
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
> Hmm, I just reverted to the previous code without actually thinking
> about it. But after checking this more closely, I find that passing
> non-nil LEXICAL to `eval' doesn't really do anything for compiled
> functions anyway: the "lexicalness" has already been applied when
> compiling. E.g., the above change has no effect on the attached tests.
If the interactive spec has been compiled (as was always the case until
now), then indeed it shouldn't make a difference. But if the byte-code
object was built by hand (or with the change you intended to install)
the interactive spec could be non-compiled, in which case the LEXICAL
arg to `eval` can have an effect.
So yes, it's not super important, but I think this part of your patch
should not have been reverted.