[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master fails to build on FreeBSD when ACL support is on
From: |
Glenn Morris |
Subject: |
Re: master fails to build on FreeBSD when ACL support is on |
Date: |
Fri, 19 Jan 2018 16:17:25 -0500 |
User-agent: |
Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) |
Stefan Monnier wrote:
> Looking at the history of the code, the temp-file code started with
>
> (make-temp-file target-file)
>
> which seems to me to be the result of an oversight: the original coder
> probably didn't realize that such a call would either create the temp
> file in the same directory as target-file or under /tmp depending on
> whether target-file is relative or absolute.
>
> Furthermore, later the code does `rename-file` which is an operation
> which works much better when the old name and new new are both in the
> same partition. So I think the intention of the code was to always put
> the tempfile next to the target-file.
You're absolutely right.
It was intentional in 0f34ae2 that the tempfile be on the same
filesystem as the target file, for the usual reasons.
I had actually been meaning to mention that 785a4a1 changed that,
but never got round to it.
- master fails to build on FreeBSD when ACL support is on, Joseph Mingrone, 2018/01/16
- Re: master fails to build on FreeBSD when ACL support is on, Paul Eggert, 2018/01/16
- Re: master fails to build on FreeBSD when ACL support is on, Eli Zaretskii, 2018/01/16
- Re: master fails to build on FreeBSD when ACL support is on, Joseph Mingrone, 2018/01/18
- Re: master fails to build on FreeBSD when ACL support is on, Stefan Monnier, 2018/01/19
- Re: master fails to build on FreeBSD when ACL support is on, Eli Zaretskii, 2018/01/19
- Re: master fails to build on FreeBSD when ACL support is on, Stefan Monnier, 2018/01/19
- Re: master fails to build on FreeBSD when ACL support is on,
Glenn Morris <=
- Re: master fails to build on FreeBSD when ACL support is on, Glenn Morris, 2018/01/20
- Re: master fails to build on FreeBSD when ACL support is on, Paul Eggert, 2018/01/20
- Re: master fails to build on FreeBSD when ACL support is on, Paul Eggert, 2018/01/19
- Re: master fails to build on FreeBSD when ACL support is on, Michael Albinus, 2018/01/20
- Re: master fails to build on FreeBSD when ACL support is on, Paul Eggert, 2018/01/20
- Re: master fails to build on FreeBSD when ACL support is on, Michael Albinus, 2018/01/21
- Re: master fails to build on FreeBSD when ACL support is on, Eli Zaretskii, 2018/01/20
- Re: master fails to build on FreeBSD when ACL support is on, Joseph Mingrone, 2018/01/20
- Re: master fails to build on FreeBSD when ACL support is on, Joseph Mingrone, 2018/01/20
- Re: master fails to build on FreeBSD when ACL support is on, Paul Eggert, 2018/01/20