[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Preview: portable dumper

From: Daniel Colascione
Subject: Re: Preview: portable dumper
Date: Thu, 15 Feb 2018 14:13:39 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 02/14/2018 08:28 PM, Stefan Monnier wrote:
I've pushed the portable dumper to the pdumper Savannah branch. It should
support a fully PIC Emacs.

Thank you very much Daniel.  I hope this can move to master soon.
I just tried it (on Debian testing, with the latest commit at the time,
i.e. 5232a17c365f871a84603caba81712415a260042) and here's my experience:

- compilation fails with

     In file included from character.h:27:0,
                      from buffer.h:27,
                      from pdumper.c:18:
     pdumper.c: In function ‘intmax_t_to_lisp’:
     pdumper.c:699:29: error: conversion to ‘EMACS_INT {aka int}’ from 
‘intmax_t {aka long long int}’ may alter its value [-Werror=conversion]
          return INTEGER_TO_CONS (value);  \

Fixed. I'm tempted to just convert INTEGER_TO_CONS to a pair of functions (one signed, one unsigned) that just take an {,u}intmax_t.

     pdumper.c:2468: Emacs fatal error: assertion failed: vector_nbytes 
((struct Lisp_Vector *) in) == out_size

Modified the code to tolerate end-of-pseudovector padding in 32-bit builds.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]