[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-26 6ddb4bd: Fix 'vc-git--program-version'
From: |
Eli Zaretskii |
Subject: |
Re: emacs-26 6ddb4bd: Fix 'vc-git--program-version' |
Date: |
Fri, 16 Feb 2018 19:22:20 +0200 |
> From: Glenn Morris <address@hidden>
> Cc: Eli Zaretskii <address@hidden>
> Date: Fri, 16 Feb 2018 11:56:05 -0500
>
> > * lisp/vc/vc-git.el (vc-git--program-version): Fix the function to
> > work with Git for Windows.
> > - (string-match "git version \\([0-9.]+\\)$"
> > - version-string))
> > + ;; Git for Windows appends ".windows.N" to the
> > + ;; numerical version reported by Git.
> > + (string-match
> > + "git version \\([0-9.]+\\)\\(\.windows.[0-9]+\\)$"
> > + version-string))
>
> Surely this breaks on all non-MS Windows platforms?
Given how much time it was "broken" on Windows without anyone
noticing, isn't it just fair that we leave it "broken" on non-Windows
platforms for approximately the same time?