[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: pdumper test failures: invalid faces

From: Daniel Colascione
Subject: Re: pdumper test failures: invalid faces
Date: Fri, 16 Feb 2018 10:30:44 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 02/16/2018 10:23 AM, Glenn Morris wrote:

It's fantastic to see a portable dumper for Emacs!

"make check" has a number of failures, which I assume are not specific
to my machine. Many are to do with invalid faces. A minimal example
might be:

./src/emacs -Q --batch --eval "(describe-face 'shadow)"
-> "Invalid face: tooltip"

Thankfully, the tooltip face does exist when we start Emacs for interactive use, so I suspect some kind of face-initialization weirdness, not fundamental dump-restoration breakage.

pdumper.c has no copyright header
pdumper.h, fingerprint.h, fingerprint-dummy.c have outdated copyright years
make-fingerprint.c has outdated and probably bogus years

Yeah. The pdumper branch will need a bit of cleanup and documentation before we merge it into master.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]