[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes

From: Dmitry Gutov
Subject: Re: [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes
Date: Wed, 21 Feb 2018 18:33:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0

On 2/21/18 12:06 PM, Richard Stallman wrote:
[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

   > Isn't it weird how we have an Objective-C specific function inside
   > add-log.el?

It makes sense for add-log.el to support all sorts of obscure languages.

It would be silly, code organization-wise. Major modes should contain that support code. And indeed, they do that via add-log-current-defun-function or add-log-current-defun-header-regexp. objc-mode sets both variables.

If change-log-get-method-definition is not used anywhere, maybe that failure
to call it is a bug.

It seems to me people simply forgot to remove it after the code was factored out.

Around Emacs 20.1, the definition of add-log-current-defun was much longer and called this function (named differently back then), among many other things.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]