[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 100e339: Update from gnulib

From: Paul Eggert
Subject: Re: [Emacs-diffs] master 100e339: Update from gnulib
Date: Mon, 26 Feb 2018 15:26:38 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 02/26/2018 12:25 PM, Ken Brown wrote:
On 2/1/2018 12:21 PM, Paul Eggert wrote:
+# if defined __CYGWIN__
+/* The 'environ' variable is defined in a DLL. Therefore its declaration needs +   the '__declspec(dllimport)' attribute, but the system's <unistd.h> lacks it.
+   This leads to a link error on 64-bit Cygwin when the option
+   -Wl,--disable-auto-import is in use.  */
+_GL_EXTERN_C __declspec(dllimport) char **environ;
+# endif

This breaks the build on 32-bit Cygwin.  The build fails as follows:

  CCLD     make-docfile.exe
/tmp/ccZciFa6.o: In function `main':
/home/kbrown/src/emacs/i686/lib-src/../../master/lib-src/emacsclient.c:1740: undefined reference to `_imp__environ'
collect2: error: ld returned 1 exit status

Bruno is aware of the issue; I first noticed it while building clisp and reported it there.  But I thought I should report it here too in case others bump into it.

Thanks for the heads-up. Does the attached patch fix the problem for you? If so, I can install it until Bruno comes up with something better.

Attachment: unistd.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]