Re: [Emacs-diffs] master 2291d9a: Fix python.el for Emacs 24, bump ELPA version to 0.26.1 (Bug#30633)

[Noam Postavsky]

On Wed, Feb 28, 2018 at 2:55 AM, Michael Albinus <address@hidden> wrote:
> Stefan Monnier <address@hidden> writes:
>
>>          (file-name (expand-file-name (file-local-name file-name)))
>>          (temp-file-name (when temp-file-name
>>                            (expand-file-name
>>                             (file-local-name temp-file-name)))))
>>
>> I don't understand how/why it makes sense to apply expand-file-name on
>> its return value.  Shouldn't this be
>>
>>          (file-name (file-local-name (expand-file-name file-name)))
>>          (temp-file-name (when temp-file-name
>>                            (file-local-name
>>                             (expand-file-name temp-file-name)))))
>>
>> ?
>
> Yes. If, for example, file-name is "/ssh:address@hidden:~/what/ever", the
> former forms might fail, because "~/what/ever" could be expanded
> differently on local and remote hosts.

Thanks, I fixed this and the other issues Stefan pointed out.

[1: 4a09341921]: 2018-03-01 22:07:21 -0500
  Fix issues turned up by previous python.el change
  
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4a0934192176fb8e372170f5f028edcf0f8cbdc3