[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Cherrypicking commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto e

From: Philipp Stephani
Subject: Re: Cherrypicking commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26
Date: Thu, 15 Mar 2018 19:37:57 +0000

Eli Zaretskii <address@hidden> schrieb am Do., 15. März 2018 um 20:07 Uhr:
> From: Philipp Stephani <address@hidden>
> Date: Thu, 15 Mar 2018 18:34:27 +0000
> would it be OK to cherrypick commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto the release
> branch? It fixes a bug that makes filenotify watches essentially unusable with quoted filenames, and is very
> short and localized.

How can anything related to quoted file name be urgent to fix?

Quoted filenames are a core Emacs function that is prominently documented, see e.g. https://www.gnu.org/software/emacs/manual/html_node/emacs/Quoted-File-Names.html. They are also the only reliable method for external scripts and libraries to ensure that Emacs doesn't mangle a local filename in unpredictable ways. Therefore it's very important that quoted filenames are bugfree.
Perhaps even more importantly, that commit fixes a regression:
emacs -Q -batch -l filenotify --eval="(file-notify-rm-watch (file-notify-add-watch \"/:/tmp/\" '(change) 'ignore))"
works in master and Emacs 25.2, but not with the release branch.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]