[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Performance issue w/ `cl-loop`s `collect...into`

From: Stefan Monnier
Subject: Re: Performance issue w/ `cl-loop`s `collect...into`
Date: Sun, 08 Apr 2018 21:59:25 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> Here's a second, cleaner attempt that separates the `cl--loop-handle-accum`
> function into two functions, one to deal with lists and one to deal w/
> non-lists.
> The tail-tracking optimizing is also applied to `append(ing)` and
> `nconc(ing)`.

Thanks.  Looks good.
I see you've dropped the (eq var cl--loop-accum-var) optimization.
Have you tried to measure the effect?


> +(defun cl--loop-handle-accum (def)
> +  (cond
> +    (cl--loop-accum-var cl--loop-accum-var)

You can write this line as just


-- Stefan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]