[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: comments about jsonrpc.el

From: Filipp Gunbin
Subject: Re: comments about jsonrpc.el
Date: Wed, 13 Jun 2018 22:09:19 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin)

Hi João,

On 10/06/2018 12:39 +0100, João Távora wrote:

> In the newer version it doesn't say that, but even in that version I am
> pretty sure that `make-timer' was a lambda that checks the `timer`
> variable before actually making one.

No, that version didn't check the `timer' var inside the lambda..

> BTW, it's better to use diffs to highlight source code bits, it provides
> context, people do it quite extensively in this group.  Also add the git
> commit hash (or if the code comes from an email, indicate the origin of
> the email )

Yep, I don't know why I didn't post the diff :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]