[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: pcase: Semantics of atom QPATS

From: Michael Heerdegen
Subject: Re: pcase: Semantics of atom QPATS
Date: Sat, 16 Jun 2018 09:32:10 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

> > Ok.  Is this patch ok for emacs-26?
> Changes in documentation and comments are always okay there, but I'm
> uneasy with changes that modify behavior.  Why is it important to
> support non-integer numbers in Emacs 26.2?

It's not important, no I thought it would be harmless, but master is ok
for me.

> > -   ((or (stringp qpat) (integerp qpat) (symbolp qpat)) `',qpat)
> > +   ((or (stringp qpat) (numberp qpat) (symbolp qpat)) `',qpat)
> Any reasons to use numberp and not number-or-marker-p?

Is it likely that someone constructs a pcase pattern with a literal
marker in it?  Note this is about the pattern, not about the matched


reply via email to

[Prev in Thread] Current Thread [Next in Thread]