emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH] Per-window face support


From: Daniel Colascione
Subject: Re: [RFC PATCH] Per-window face support
Date: Sat, 16 Jun 2018 07:24:13 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 06/16/2018 03:29 AM, Eli Zaretskii wrote:
Date: Fri, 08 Jun 2018 12:15:44 +0300
From: Eli Zaretskii <address@hidden>
Cc: address@hidden

Daniel, you never answered my question below:

+    if (w) {
+      Lisp_Object found = assq_no_quit (parameter, w->window_parameters);
+      if (!NILP (found) && EQ (XCDR (found), value))
+        match = true;
+    }

[...]

Also, I wonder whether EQ should actually be equal_no_quit, because
the latter would allow parameters with values that are not just
integers or symbols.

I still wonder why we only allow EQ there, it sounds unnecessarily
restrictive.

Because there's no need for greater power. All you need is simple classification.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]