[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Clarify `pcase' `rx' pattern doc

From: Michael Heerdegen
Subject: Re: Clarify `pcase' `rx' pattern doc
Date: Fri, 06 Jul 2018 19:57:29 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

> How about the below?

> + [...]  If the target is not a string, signal an error.

We want to change that, so I think you can drop that sentence.

>  In addition to the usual `rx' constructs, REGEXPS can contain the
>  following constructs:
> -  (let VAR FORM...)  creates a new explicitly numbered submatch
> -                     that matches FORM and binds the match to
> -                     VAR.
> +  (let VAR SEXP...)  creates a new explicitly numbered submatch
> +                     that matches regular expressions SEXP, and
> +                     binds the match to VAR.
>    (backref VAR)      creates a backreference to the submatch
>                       introduced by a previous (let VAR ...)
> -                     construct.
> +                     construct.  VAR can be the same symbol
> +                     in the first argument of the corresponding
> +                     (let VAR ...) construct, or it can be a
> +                     submatch number.  It matches the referenced
> +                     submatch.

Looks ok to me.  But can we remove the sentence saying "Multiple
occurrences of the same VAR refer to the same submatch."?  It's
completely redundant IMHO.

Then, can you please install it (maybe with my issues fixed)?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]