[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] New option to make C-x 4 a use file-less ChangeLog buffers (

From: Stefan Monnier
Subject: Re: [PATCH] New option to make C-x 4 a use file-less ChangeLog buffers (was Re: git history tracking across renames (and emacs support))
Date: Mon, 16 Jul 2018 08:33:23 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> To tell you the truth, I was hoping to *avoid* uniquify here.  IMO, it
> is designed for those cases where the file creator could reasonably be
> convinced that his/her file would be unique (probably within a
> dir/project).  This is not one of these cases, since Emacs is generally
> useful for working more than one project at the same time.

I don't follow.  `uniquify` is designed specifically for those cases
where the same file name can occur in multiple projects and lets you see
"foo|bar" and "foo|baz" instead of "foo" and "foo<1>".

> In practice, I find the "|<uniqueness>" much harder to read,

Harder then what?  In any case, you should be able to get pretty much
the same as what your patch currently does by setting
uniquify-buffer-name-style and uniquify-min-dir-content appropriately.

> This would also avoid the added complexity that you foresee.

Yes, but it's not as nice for the user.

> Right, that is clearer.  But will it fit in the miniscule column limit? 

We can split it into two sentences if needed ;-)

> As I said, I was hoping to avoid this.  "*ChangeLog for
> <full-project-path>*" seems acceptable to me, but we could shorten it to
> $HOME or sth (how?).

[ We call those things "filenames" rather than "path" in the GNU project.  ]

These are awfully long, with a lot of redundancy in the middle, making
it harder to find the relevant information.

This part will be easy to fix if you `setq` a buffer-local variable in the
buffer, e.g.:

    (defun add-log--changelog-buffer-p (file-name buffer)
      (equal file-name (or buffer-file-name add-log--buffer-file-name)))

-- Stefan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]