[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] New option to make C-x 4 a use file-less ChangeLog buffers (

From: Eli Zaretskii
Subject: Re: [PATCH] New option to make C-x 4 a use file-less ChangeLog buffers (was Re: git history tracking across renames (and emacs support))
Date: Sat, 21 Jul 2018 13:42:40 +0300

> From: João Távora <address@hidden>
> Cc: address@hidden,  address@hidden,  address@hidden,  address@hidden,  
> address@hidden
> Date: Tue, 17 Jul 2018 00:02:47 +0100
> > Thanks.  I didn't forget about this and didn't lose it.  I'm just a
> > bit busy these days, and may need a couple more days before I get to
> > reviewing this.  I'm saving Stefan's comments and your responses for
> > that time.
> >
> > Stay tuned.
> No worries.  When you do get around to it, have a look at the patch I
> attach to this mail instead, because it integrates a few of Stefan's
> suggestions (the part we don't yet agree is how, if at all, to add
> uniquify.el into the equation...).

Looks reasonable, thanks.

> +(defcustom add-log-use-pseudo-changelog t
> +  "If non-nil, don't create ChangeLog files for log entries."
> +  :type :boolean)

I frequently find that what we say in the doc string is a very good
hint on how to name the variable.  So how about
add-log-don't-create-change-log-file instead?

Also, this needs a :version tag.

> +(defun add-log--pseudo-changelog-buffer-name (changelog-file-name)
> +  "Compute suitable name for a pseudo-ChangeLog buffer."
> +  (format "*changes to %s*"
> +          (abbreviate-file-name
> +           (file-name-directory changelog-file-name))))

Would the name of the buffer be something like "*changes to ChangeLog*"?
That's awkward, IMO.  How about just "*ChangeLog*" instead?

The above are minor nits, so what else is left that needs to be agreed


reply via email to

[Prev in Thread] Current Thread [Next in Thread]