[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tabulated-list sort icon is reversed

From: Philippe Vaucher
Subject: Re: tabulated-list sort icon is reversed
Date: Fri, 10 Aug 2018 22:10:21 +0200

On Fri, Aug 10, 2018 at 4:52 PM Yuri Khan <address@hidden> wrote:
On Fri, Aug 10, 2018 at 9:15 PM Philippe Vaucher
<address@hidden> wrote:

> To be honest I'm losing a bit of steam here, I now suspect this patch will never land because the ACSII part is unsolvable, and because I guess that using an image requires quite a lot of refactoring (displaying an inline image instead of a character is likely to be complicated).

Fortunately there’s an easy escape hatch from this problem: Make it a
defcustom. Then we can spend an inordinate amount of time bikeshedding
the default.

Good idea! Here's a patch in that direction, here are things that I'm not sure about:
  • variable name? `tabulated-list-sort-ascending-indicator`? `tabulated-list-sort-ascending-icon`? For ASCII, `-ascii` or `-glyphless`?
  • group definition: does tabulated-list belong to another group?
  • 4 defcustoms or 2? For example, it could be `(defcustom tabulated-list-sort-ascending-texts '(" ▼" "v"))`, that way you customize both icons at the same time (it could even be only one defcustom with :asc keywords etc)

Attachment: 0001-Allow-customization-of-sort-indicators-in-tabulated-.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]