[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: syntax based indentation for SQL files (ELPA package proposal)

From: Andy Moreton
Subject: Re: syntax based indentation for SQL files (ELPA package proposal)
Date: Tue, 02 Oct 2018 14:48:40 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt)

On Tue 02 Oct 2018, Stefan Monnier wrote:

>> This patch looks like it has been applied in the wrong place.  Emacs
>> builtin code should not depend on an external package.  Why did you add
>> this change into emacs, rather than the package that defines
>> sqind-minor-mode ?
> It doesn't actually depend on sql-indent.  It just makes use of it
> when available.  Given that sql-indent is in GNU ELPA, I think this is
> perfectly acceptable (and I'm pretty sure we have other similar cases
> already in emacs.git, some of which for packages that aren't even in

This is still the wrong way around though: the customisation is only
needed by users of sqind-minor-mode, and otherwise adds bloat (and
possibly bugs) to emacs core, for no benefit to any other users.

This approach is misguided. The customisation to support the GNU ELPA
package should be in the GNU ELPA package, not in emacs core.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]