[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] open bookmark in other frame

From: Karl Fogel
Subject: Re: [PATCH] open bookmark in other frame
Date: Thu, 08 Nov 2018 16:54:18 -0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Pierre-Yves Luyten <address@hidden> writes:
>Oops i used to just work with eval-buffer on the lisp i needed, and i
>can see now this is not the right workflow for testing a patch.
>So now i rather build Emacs to test patch properly, and obviously as
>you wrote adding the autoload magic comment fixed the issue. So here
>is the patch with this.

Thanks, Pierre-Yves.  I've applied the patch and committed it now.  As it's a 
new feature, not a bug fix, it went to the master branch, so it'll be in the 
next major release of Emacs.

I modified the log message a bit.  I changed it to match the style recommended 
in CONTRIBUTING (that is, to put a summary line at the top before giving a 
ChangeLog-style entry below that), and I added a line at the bottom noting that 
I had applied the patch, because otherwise there would be no way to trace the 
full audit trail.

By the way, I realize that when you wrote the log message you were probably 
just following the examples you saw from looking at existing log messages.  
Some developers are still using an older log message format, but the 
CONTRIBUTING file is clear about the modern format, so I though this change 
should provide an up-to-date example for whoever the next contributor is :-).

Here's the commit:

  | commit f3345dee4b40293547d10963c6cb242a62e424ba
  | Author: Pierre-Yves Luyten <address@hidden>
  | Date:   Sat Oct 13 22:06:41 2018 +0200
  |     Add functions to open a bookmark in another frame
  |     * lisp/bookmark.el (bookmark-jump-other-frame): New function.
  |     Bind in bookmark-map.
  |     (bookmark-bmenu-other-frame): New function.
  |     Bind in bookmark-bmenu-mode-map.
  |     Patch applied by Karl Fogel.

Thank you for the improvement to Emacs!

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]