[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-26 03bb7a8: Avoid clearing echo-area message by

From: Eli Zaretskii
Subject: Re: [Emacs-diffs] emacs-26 03bb7a8: Avoid clearing echo-area message by auto-save-visited-file-name
Date: Tue, 27 Nov 2018 07:44:19 +0200

> From: Eric Abrahamsen <address@hidden>
> Date: Mon, 26 Nov 2018 13:03:54 -0800
> Eli Zaretskii <address@hidden> writes:
> >> From: Eric Abrahamsen <address@hidden>
> >> Date: Mon, 26 Nov 2018 12:11:46 -0800
> >> 
> >> Well... I highly doubt I've seen something you haven't, but the
> >> following seems to work correctly, doesn't it?
> >
> > How can I tell?
> The "Hi!" message remains visible after the `map-y-or-n-p' call returns.

That's not what I meant.  My problem is that this change was done on
the release branch, and is part of both auto-save-visited-file-name
and of save-some-buffers, the latter is an important frequently used
command.  I need to be absolutely sure using with-temp-message doesn't
change these use cases in any significant way, to be able to use it on
the release branch.  And neither the non-trivial code of
with-temp-message nor its doc string allow me to convince myself that
this is the case.

So if you think my change is equivalent to using with-temp-message,
I'm okay with doing that on master, but on emacs-26 I would need a
much stronger evidence than just its working in a single simple use


P.S. May I please request that people who watch the emacs-diffs list
and respond to changes please subscribe to the bug list, where the
changes are normally discussed for several days before they are
pushed?  It is very inefficient, to say the least, to have a change
discussed, only to hear comments on it after it's already pushed.  The
discussions on the bug list, and the few days we usually wait for more
comments, are precisely to allow more people to chime in.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]