[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Identifying the face between STRETCH and right fringe.

From: Robert Pluim
Subject: Re: Identifying the face between STRETCH and right fringe.
Date: Wed, 28 Nov 2018 09:36:53 +0100

Eli Zaretskii <address@hidden> writes:

>> From: Robert Pluim <address@hidden>
>> Cc: address@hidden
>> Date: Tue, 27 Nov 2018 20:14:14 +0100
>> >> > Why does NS use indices here, and not RGBA values?
>> >> 
>> >> Probably because NS doesnʼt really use the RGBA values directly at
>> >> all, but uses the indices all the time.
>> >
>> > So where does the RGBA value in FRAME_BACKGROUND_PIXEL come from?
> Can you answer this question?

Itʼs set by the NS version of x_set_background_color, so itʼs correct,
just not the same format as the face background colour.

>> I love those rare moments when I implement something one way, and then
>> Eli tells me to do it that way :-)
>> In theory there are a couple of other fields in the face structure
>> that might need the same type of treatment, but I didnʼt see any code
>> comparing them to RGBA pixel values.
>> I suck at naming things, comments welcome.
> LGTM, thanks.  Let's wait for comments from NS people.
>> -      && face->background == FRAME_BACKGROUND_PIXEL (f)
>> +      && FACE_COLOR_TO_PIXEL(face->background, f) == FRAME_BACKGROUND_PIXEL 
>> (f)
>                                ^
> Please leave one space between the macro name and the opening paren.

Fixed (plus a missing space at the end of a comment sentence).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]