[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master build broken [macOS]
From: |
Eli Zaretskii |
Subject: |
Re: master build broken [macOS] |
Date: |
Mon, 03 Dec 2018 19:57:42 +0200 |
> From: Paul Eggert <address@hidden>
> Date: Mon, 3 Dec 2018 08:27:20 -0800
> Cc: Filipp Gunbin <address@hidden>, address@hidden
>
> Thanks for the fix; I installed it. GNU/Linux and Solaris <sys/socket.h>
> have SOCK_CLOEXEC and I didn't catch the typo for non-SOCK_CLOEXEC
> systems like macOS.
>
> It is odd that even after all these years there's no way to create
> sockets in a thread-safe way on macOS. This doesn't matter for
> emacsclient but I assume it does matter for src/process.c.
Btw, why do we want to mark the emacsclient sockets non-inheritable?
According to my reading of the code, we set up the socket after we
fork/exec, so socket inheritance to the Emacs daemon is not the
problem, right? If so, what inheritance would be the problem? Just
wondering.