[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 1691a51: * lisp/emacs-lisp/map.el: Make the fun
|
From: |
Stefan Monnier |
|
Subject: |
Re: [Emacs-diffs] master 1691a51: * lisp/emacs-lisp/map.el: Make the functions generic |
|
Date: |
Fri, 14 Dec 2018 11:05:40 -0500 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
> Sorry, I don't have commit rights, so I attach the corresponding patch,
> which also fixes an argument naming discrepancy in 'map-put!'.
Thanks, pushed.
> I noticed that test/lisp/emacs-lisp/map-tests.el still uses map-put,
> which is now obsolete. Should these tests be updated to test 'map-put!'
> instead?
We should add tests for map-put!, yes.
We can keep the old tests for map-put for now, since we still
(temporarily) care about providing correct behavior for map-put.
Stefan