[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: harfbuzz 2f72162: Fix crash in the Cairo build

From: Robert Pluim
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Fri, 14 Dec 2018 17:16:46 +0100

Eli Zaretskii <address@hidden> writes:

>> From: Robert Pluim <address@hidden>
>> Date: Fri, 14 Dec 2018 13:18:41 +0100
>> Cc: Ari Roponen <address@hidden>
>> Eli, what would be your preferred type of solution to avoid this in
>> future?
> If at all possible, I prefer a single definition of each struct, with
> as few #ifdef's as possible.  If some member is not used in some
> configuration, I prefer to have it anyway, unless it cannot be
> compiled in the configuration(s) that don't use it (e.g., because it
> uses a data type that is only visible in some configurations).

Aligning ftfont.c and ftcrfont.c is pretty easy. Did you want me to
try to unify xftfont.c in there as well? Iʼm tempted to get rid of
ftxfont.c as well, unless someone is actually still using that. [1]


[1] How many different font backends can we come up with using only 3

reply via email to

[Prev in Thread] Current Thread [Next in Thread]