[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: harfbuzz 2f72162: Fix crash in the Cairo build

From: Robert Pluim
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Tue, 18 Dec 2018 09:49:55 +0100

Eli Zaretskii <address@hidden> writes:

>> From: Robert Pluim <address@hidden>
>> Cc: address@hidden,  address@hidden
>> Date: Mon, 17 Dec 2018 13:41:11 +0100
>> >> Aligning ftfont.c and ftcrfont.c is pretty easy. Did you want me to
>> >> try to unify xftfont.c in there as well?
>> >
>> > If that makes sense, i.e. if the commonality seems to justify that,
>> > then yes.
>> >
>> I had a quick go at this. Iʼve not measured the memory difference, but
>> I can do if people thinks this refactor is worth it. Apart from the
>> unification of the three struct definitions, most of the patch is
>> mechanical changes.
> Thanks, this LGTM, and is a significant improvement, IMO.  If no one
> objects in a few days, please push.
> P.S.  Will this have any problems with the harfbuzz branch?

Apart from having to adjust the addition to the struct in question
done on the harfbuzz branch, I donʼt think so. Probably there will be
a merge conflict, I can help out with that if needed.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]