[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: display-buffer-use-some-frame

From: Stephen Leake
Subject: Re: display-buffer-use-some-frame
Date: Sun, 23 Dec 2018 10:23:54 -0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt)

Stephen Leake <address@hidden> writes:

> martin rudalics <address@hidden> writes:
>> - In the call
>>           (window--display-buffer
>>            buffer window 'frame alist display-buffer-mark-dedicated)
>>   you should write 'reuse instead of 'frame.  The latter means that a
>>   new frame has been made but you just reuse an existing window.  I
>>   noticed this because I made the same error in (an undocumented part
>>   of) 'display-buffer-in-child-frame'.
> I'll fix this after the test below.

Committed in emacs-26

>> Also, I wonder why you call
>> 'frame-first-window' here:
>>                            (not (window-dedicated-p
>>                                  (or
>>                                   (get-lru-window frame)
>>                                   (frame-first-window frame)))))
> I don't remember. I'll test for a while without it.

No problems with the testing. get-lru-window never returns a dedicated
window, so this can be simplified to:

  (let* ((predicate
          (or (cdr (assq 'frame-predicate alist))
              (lambda (frame)
                (and (not (eq frame (selected-frame)))
                     (get-lru-window frame)))))
Committed in emacs-26

-- Stephe

reply via email to

[Prev in Thread] Current Thread [Next in Thread]