[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Linking to ImageMagick by default

From: Juri Linkov
Subject: Re: Linking to ImageMagick by default
Date: Sat, 29 Dec 2018 23:31:06 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)

>> > This avoids the unnecessary calculations too late, IMO.  Since I
>> > expect most images to not require resizing, I suggest to make that
>> > frequent case as fast as it is today, which means avoid any
>> > unnecessary lookups in the image spec.  As a minimum, you don't need
>> > to look up :max-width and :max-height.  Bonus points if you avoid
>> > calling this function altogether when the image needs no resizing.
>> I’m not sure how to check whether the image needs resizing without
>> doing the lookups for :width, :height, :max-width, etc.
> Maybe I'm misreading the code, but it looks to me you only need
> :scale, :width, and :height.  Am I missing something?

It's easier in application code just to set :max-width/:max-height
to the window dimensions and let the core to calculate its scale.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]