[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: project--completing-read-strict breaks ada-mode project completion t
From: |
Stephen Leake |
Subject: |
Re: project--completing-read-strict breaks ada-mode project completion table |
Date: |
Wed, 16 Jan 2019 14:02:18 -0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) |
Stephen Leake <address@hidden> writes:
> Commit 8f9d93f3054 (Dmitry Gutov 2018-12-29 415) breaks my ada-mode
> completion table.
>
> That commit modifies the completion table by first calling the actual
> completion table to get all the file names, then removing any common
> prefix directory, then calling completing read with that file list.
>
> This violates assumptions made within the ada-mode completion table, and
> breaks the expected completion style - it requires typing the remaining
> directory names first; the ada-mode completion table allows completing
> on the base name only.
>
> I can understand the motivation behind removing common prefixes, but the
> proper way to do that is to implement a completion style and/or table
> that does that, and make that style/table the default for projects.
>
> The ada-mode completion style and table eliminates all directories from
> the visible completion string, except the minimum needed to make the
> string unique. I think this is a better solution to the problem;
> project.el should allow the user to choose their prefered solution, by
> choosing a completion style and table.
>
> To make my source available for experimenting with, I'd like to create
> several new ELPA packages; I sent a separate email about that.
These are now in the ELPA master branch:
elpa/packages/ada-mode/ada-project.el
elpa/packages/ada-mode/env-package.el
elpa/packages/path-iterator/path-iterator.el
elpa/packages/uniquify-files/uniquify-files.el
--
-- Stephe
- Making project-files the "canonical" generic, was: Re: [Emacs-diffs] master 55ec674: * lisp/multifile.el: New file, extracted from etags.el, Dmitry Gutov, 2019/01/11
- Re: Making project-files the "canonical" generic, Stephen Leake, 2019/01/12
- Re: Making project-files the "canonical" generic, Dmitry Gutov, 2019/01/12
- Re: Making project-files the "canonical" generic, Stephen Leake, 2019/01/14
- Re: Making project-files the "canonical" generic, Stefan Monnier, 2019/01/16
- Re: Making project-files the "canonical" generic, Dmitry Gutov, 2019/01/16
- Re: Making project-files the "canonical" generic, Stefan Monnier, 2019/01/17
- Re: Making project-files the "canonical" generic, Dmitry Gutov, 2019/01/17
- project--completing-read-strict breaks ada-mode project completion table, Stephen Leake, 2019/01/16
- Re: project--completing-read-strict breaks ada-mode project completion table,
Stephen Leake <=
- Re: project--completing-read-strict breaks ada-mode project completion table, Stephen Leake, 2019/01/17
- Re: project--completing-read-strict breaks ada-mode project completion table, Dmitry Gutov, 2019/01/17
- Re: project--completing-read-strict breaks ada-mode project completion table, Stephen Leake, 2019/01/18
- Re: project--completing-read-strict breaks ada-mode project completion table, Dmitry Gutov, 2019/01/19
- Re: project--completing-read-strict breaks ada-mode project completion table, Stephen Leake, 2019/01/20
- Re: project--completing-read-strict breaks ada-mode project completion table, Dmitry Gutov, 2019/01/16
- Re: project--completing-read-strict breaks ada-mode project completion table, Stefan Monnier, 2019/01/17
- Re: project--completing-read-strict breaks ada-mode project completion table, John Yates, 2019/01/17
- Re: project--completing-read-strict breaks ada-mode project completion table, Dmitry Gutov, 2019/01/17
- Re: project--completing-read-strict breaks ada-mode project completion table, Stefan Monnier, 2019/01/17